1 comment:
File src/drivers/usb/pci_xhci/pci_xhci.c:
I didn't want to maintain another list of PCI_IDs.
It is already done in a number of drivers in coreboot. This might one of the first ones outside of SoC directory, but I think it helps to keep the devicetree consistent.
If we add soc_get_controller_wake_gpe I think it should be in a more common location.
Do you mean the header file for declaration? Probably `device/xhci.h`?
I don't think that this driver should implement the weak method since this is pci_xhci and not soc code.
Weak definition that returns -1 can be placed here. It is for those SoCs that do not really have a GPE associated with XHCI wake (though I haven't really seen one). We can also completely skip the weak definition and always require SoC to provide this callback if using pci_xhci driver.
To view, visit change 41900. To unsubscribe, or for help writing mail filters, visit settings.