Attention is currently required from: Felix Singer, Lance Zhao, Nico Huber, Johnny Lin, Tim Wawrzynczak, Angel Pons, Arthur Heymans, Michael Niewöhner, Patrick Rudolph.
2 comments:
File util/inteltool/inteltool.c:
Patch Set #13, Line 666: if (!dump_coremsrs) {
Sometimes, the best way to solve a problem is to remove what causes the problem to exist. 😄 […]
I would say this seriously, without humor, it's just like you said )
Also... The less code, the faster the review. This relates to all large projects.
File util/inteltool/inteltool.c:
if (sscanf(optarg, "%u-%u", &cores_range_start, &cores_range_end) == 1) {
/* the end of the range is not specified - only for one core */
cores_range_end = cores_range_start;
} else if (cores_range_end < cores_range_start) {
printf("Error: invalid cores range <%u-%u>!\n",
cores_range_start, cores_range_end);
exit(1);
}
I was thinking of something like this: […]
Yes, I agree with you, this check is necessary. Thx
To view, visit change 35919. To unsubscribe, or for help writing mail filters, visit settings.