Attention is currently required from: Tim Crawford, Nico Huber, Jeremy Soller.
3 comments:
File src/soc/intel/cannonlake/fsp_params.c:
Patch Set #6, Line 558: = {0}
Done
Originally, this was non-static, which was wrong in its own way (see my reasoning on earlier patchsets), but required the initializer.
File src/soc/intel/cannonlake/fsp_params.c:
Patch Set #7, Line 540: reserved1
You can omit the names for reserved fields. Personally, I'd also align the colons, but that's up to personal preference (coding style doesn't say anything about it)
Patch Set #7, Line 582: params->SiNumberOfSsidTableEntry = i;
Note that this approach will result in FSP programming the default SVID/SSID values when neither xHCI nor HDA are present in the devicetree. This would be an extremely unlikely scenario, though.
To view, visit change 49104. To unsubscribe, or for help writing mail filters, visit settings.