Attention is currently required from: Ashish Kumar Mishra, Dinesh Gehlot, Elyes Haouas, Eran Mitrani, Felix Singer, Jakub Czapiga, Jérémy Compostella, Kapil Porwal, Subrata Banik, Tarun.
View Change
3 comments:
File src/soc/intel/pantherlake/bootblock/report_platform.c:
File src/soc/intel/pantherlake/include/soc/iomap.h:
Patch Set #32, Line 19: #define SAF_BASE_ADDRESS 0xfa000000
> As per latest FAS, SAF BASE address is 0xfa000000. […]
Hi Subrata, there is a FAS v1.1, the SAF is placed to 0xfa000000. Previous SAF(Above 4GB) in v0.5 is now replaced with hole.
File src/soc/intel/pantherlake/include/soc/pm.h:
Patch Set #32, Line 45:
SMI_STS_BITS 32
#define XHCI_SMI_STS_BIT 31
#define ME_SMI_STS_BIT 30
#define ESPI_SMI_STS_BIT 28
#define GPIO_UNLOCK_SMI_STS_BIT 27
#define SPI_SMI_STS_BIT 26
#define SCC_SMI_STS_BIT 25
#define MONITOR_STS_BIT 21
#define PCI_EXP_SMI_STS_BIT 20
why not here as well
Acknowledged
To view, visit change 83354. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibcfe71eec27cebf04f10ec343a73dd92f1272aca
Gerrit-Change-Number: 83354
Gerrit-PatchSet: 33
Gerrit-Owner: Saurabh Mishra <mishra.saurabh@intel.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot@google.com>
Gerrit-Reviewer: Eran Mitrani <mitrani@google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga@google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal@google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik@google.com>
Gerrit-Reviewer: Tarun <tstuli@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Anil Kumar K <anil.kumar.k@intel.com>
Gerrit-CC: Ashish Kumar Mishra <ashish.k.mishra@intel.com>
Gerrit-CC: Balaji Manigandan <balaji.manigandan@intel.com>
Gerrit-CC: Bora Guvendik <bora.guvendik@intel.com>
Gerrit-CC: Elyes Haouas <ehaouas@noos.fr>
Gerrit-CC: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Gerrit-CC: Hannah Williams <hannah.williams@intel.com>
Gerrit-CC: Jérémy Compostella <jeremy.compostella@intel.com>
Gerrit-CC: Ravishankar Sarawadi <ravishankar.sarawadi@intel.com>
Gerrit-CC: Sanju Jose Thottan <sanjujose.thottan@intel.com>
Gerrit-CC: Saurabh Mishra <mishra.saurabh@intel.corp-partner.google.com>
Gerrit-CC: Vikrant L Jadeja <vikrant.l.jadeja@intel.com>
Gerrit-CC: Wonkyu Kim <wonkyu.kim@intel.com>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Gerrit-Attention: Ashish Kumar Mishra <ashish.k.mishra@intel.com>
Gerrit-Attention: Eran Mitrani <mitrani@google.com>
Gerrit-Attention: Subrata Banik <subratabanik@google.com>
Gerrit-Attention: Jakub Czapiga <czapiga@google.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella@intel.com>
Gerrit-Attention: Kapil Porwal <kapilporwal@google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot@google.com>
Gerrit-Attention: Tarun <tstuli@gmail.com>
Gerrit-Attention: Elyes Haouas <ehaouas@noos.fr>
Gerrit-Comment-Date: Thu, 01 Aug 2024 04:55:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Saurabh Mishra <mishra.saurabh@intel.com>
Comment-In-Reply-To: Subrata Banik <subratabanik@google.com>
Comment-In-Reply-To: Elyes Haouas <ehaouas@noos.fr>