Felix Held submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved
sb/amd/pi/hudson: fix gpio.h and smi.h include location

This fixes the following compile error when trying to build the APU2
board with HAVE_SMI_HANDLER selected and the NO_SMM select removed:

In file included from src/soc/amd/common/block/gpio/gpio.c:8:
src/include/gpio.h:6:10: fatal error: soc/gpio.h: No such file or directory
6 | #include <soc/gpio.h> /* IWYU pragma: export */
| ^~~~~~~~~~~~

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: Ie06044b12f5cbcc55a2706ec566afd2eb294c62b
Reviewed-on: https://review.coreboot.org/c/coreboot/+/79846
Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M src/southbridge/amd/pi/hudson/Makefile.inc
R src/southbridge/amd/pi/hudson/include/soc/gpio.h
R src/southbridge/amd/pi/hudson/include/soc/smi.h
3 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/src/southbridge/amd/pi/hudson/Makefile.inc b/src/southbridge/amd/pi/hudson/Makefile.inc
index a7be5a9..e7ec1b7 100644
--- a/src/southbridge/amd/pi/hudson/Makefile.inc
+++ b/src/southbridge/amd/pi/hudson/Makefile.inc
@@ -36,6 +36,8 @@
smm-y += smihandler.c
smm-y += smi_util.c

+CPPFLAGS_common += -I$(src)/southbridge/amd/pi/hudson/include
+
# ROMSIG At ROMBASE + 0x20000:
# +-----------+---------------+----------------+------------+
# |0x55AA55AA |EC ROM Address |GEC ROM Address |USB3 ROM |
diff --git a/src/southbridge/amd/pi/hudson/soc/gpio.h b/src/southbridge/amd/pi/hudson/include/soc/gpio.h
similarity index 100%
rename from src/southbridge/amd/pi/hudson/soc/gpio.h
rename to src/southbridge/amd/pi/hudson/include/soc/gpio.h
diff --git a/src/southbridge/amd/pi/hudson/soc/smi.h b/src/southbridge/amd/pi/hudson/include/soc/smi.h
similarity index 100%
rename from src/southbridge/amd/pi/hudson/soc/smi.h
rename to src/southbridge/amd/pi/hudson/include/soc/smi.h

To view, visit change 79846. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie06044b12f5cbcc55a2706ec566afd2eb294c62b
Gerrit-Change-Number: 79846
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged