Patch set 45:Code-Review +2
7 comments:
mt8192 is a new design, is not copied from mt8183 or mt8173.
Ack
On architecure, mt8192 is different from mt8183 or mt8173, so no common code can use now.
Ack
File src/soc/mediatek/mt8192/include/soc/dramc_pi_api.h:
Patch Set #6, Line 157: u8 chn;
The size of structure member should be 1 or 2 or 4 bytes. […]
Ack
Patch Set #6, Line 158: u8 rank;
As above.
Ack
u8 density;
u8 *pll_mode;
u32 frequency;
u32 vcore_voltage;
Use native types?
Ack
File src/soc/mediatek/mt8192/include/soc/dramc_pi_api.h:
#define dramc_err(_x_...) printk(BIOS_ERR, _x_)
#define dramc_info(_x_...) printk(BIOS_INFO, _x_)
#if CONFIG(DEBUG_DRAM)
#define dramc_dbg(_x_...) printk(BIOS_INFO, _x_)
#else
#define dramc_dbg(_x_...)
#endif
I am sorry, HAOUAS, "should we use this for coreboot tree " means?
I think it's fine to keep it here.
File src/soc/mediatek/mt8192/include/soc/dramc_register.h:
Patch Set #1, Line 6: types.h
Yes, just use stdint.h, use types.h is also ok.
Done
To view, visit change 44699. To unsubscribe, or for help writing mail filters, visit settings.