4 comments:
File src/soc/intel/cannonlake/cnl_memcfg_init.c:
Patch Set #10, Line 19: #include <soc/gpio.h>
Why is this required?
Patch Set #10, Line 53: cnl_cfg
maybe cnl_mb_cfg?
Patch Set #10, Line 61: MemorySpdPtr00
Default value of this field is 0. Should be okay to just:
if (cnl_cfg->pop_channel[0])
mem_cfg->MemorySpdPtr00 = spd_data_ptr;
if (cnl_cfg->pop_channel[1])
mem_cfg->MemorySpdPtr10 = spd_data_ptr;
File src/soc/intel/cannonlake/include/soc/cnl_memcfg_init.h:
Patch Set #10, Line 108: Flags to indicate which channels are populated
Actually, by doing this, it will break all boards unless you update configuration for each CNL/WHL board to set these fields.
To view, visit change 31262. To unsubscribe, or for help writing mail filters, visit settings.