[coreboot-gerrit] [M] Change in coreboot[main]: drivers/intel/gma/opregion: Use CBFS cache to load VBT

[Nico Huber (Code Review)]

Attention is currently required from: Arthur Heymans, Eran Mitrani, Jakub Czapiga, Jérémy Compostella, Kapil Porwal, Nick Vaccaro, Tarun.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77886?usp=email )

Change subject: drivers/intel/gma/opregion: Use CBFS cache to load VBT
......................................................................


Patch Set 33:

(1 comment)

File src/drivers/intel/gma/opregion.c:

https://review.coreboot.org/c/coreboot/+/77886/comment/e661bfc8_a00f66ee :
PS4, Line 27: cbfs_map
> I find this quite confusing. The way you describe it, I see no difference to […]
> NB. Looking at the code below and the history of the static array, it
> looks like it was never necessary. We eventually copy the VBT to CBMEM
> anyway. So there shouldn't be a need to map twice. Probably just a
> shortcut that was taken when adding FSP/GOP support.