Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39812 )
Change subject: mb/google/dedede: Read DRAM population strap
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39812/3/src/mainboard/google/dedede...
File src/mainboard/google/dedede/romstage.c:
https://review.coreboot.org/c/coreboot/+/39812/3/src/mainboard/google/dedede...
PS3, Line 21: bool half_populated = gpio_get(GPIO_MEM_CH_SEL);
A question for checking GPIO_MEM_CH_SEL behavior.
High is for dual-channel and low for single-channel from schematic. Is it correct?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39812
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I69583f35ffc219bae9ce06bd4ba9898ed0d4d21d
Gerrit-Change-Number: 39812
Gerrit-PatchSet: 3
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Comment-Date: Wed, 25 Mar 2020 10:39:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment