In general one should always avoid indirect includes. Then again, if we insist on being consistent then every single file having printk(BIOS_xxx,...) would include loglevel.h, and we would be adding it like hundreds of files?

I prefer the indirect for loglevel and this at least makes it consistent decision.

Patch set 5:Code-Review +1

To view, visit change 31239. To unsubscribe, or for help writing mail filters, visit settings.