Attention is currently required from: Angel Pons, Arthur Heymans, Felix Held, Krystian Hebel, Kyösti Mälkki, Michał Żygowski.
Patch set 19:Code-Review +1
2 comments:
File src/device/pciexp_device.c:
Patch Set #18, Line 596: unsigned int
All `pci_find_capability(dev, PCI_CAP_ID_PCIE);` calls were assigning a value to unsigned int (with […]
I have no strong preference. Though, in general, limiting the type also constraints
the compiler in the choices of optimizations it can make. So `unsigned int` seems
fine as long as there is no benefit to a human reader when using a fixed-width
type (I see none, but can only speak for myself).
Patch Set #18, Line 721: parent's
Shouldn't the root's (real one, not what `root` variable points to) Max Payload Size be limited here […]
pciexp_scan_bus() should be called for the next pair of parent and child after
the loop below (line 760) is done with the current level. That should propagate
it further up to the root port. pciexp_sync_max_payload_size() should only run on
the upper-most level after *all* calls to pciexp_scan_bus() below a given root
port are done.
To view, visit change 77338. To unsubscribe, or for help writing mail filters, visit settings.