Attention is currently required from: Hung-Te Lin, Paul Menzel, Yu-Ping Wu.
8 comments:
Commit Message:
Patch Set #1, Line 13: mtcmos_display_power_on
nit: `mtcmos_display_power_on()`
Done
nit: `mediatek`
Done
Patch Set #1, Line 29: refacts
Do you mean `refactors`?
Done
Commit Message:
Patch Set #2, Line 7: implmentation
typo
Done
File src/soc/mediatek/common/display.c:
Patch Set #1, Line 13: configure_display
Consider renaming it to `mtk_display_init`?
Done
Patch Set #1, Line 42: if (panel->get_edid && panel->get_edid(panel) < 0)
I think we just need a local variable to store panel_serializable_data. […]
```
struct panel_serializable_data {
struct edid edid; /* edid info of this panel */
u8 init[]; /* A packed array of panel_init_command */
};
```
Since `init` is always pointing to the address next to `edid`, we can't pass `panel_serializable_data` variable and copy the serializable data from `get_mipi_cmd_from_cbfs`. I pass the pointer to get `buffer` address instead.
File src/soc/mediatek/common/include/soc/ddp_common.h:
Patch Set #1, Line 142: enum disp_path_sel {
I think this should be put in mediatek/common/.../display.h, and then include display. […]
Done
File src/soc/mediatek/common/include/soc/display.h:
Patch Set #1, Line 13: configure_panel_backlight
configure_backlight
Done
To view, visit change 79776. To unsubscribe, or for help writing mail filters, visit settings.