Attention is currently required from: Michał Żygowski, Michał Kopeć, Elyes Haouas.
View Change
1 comment:
Patchset:
Patch Set #2:
so, " case ADL_P_LP5_1:
case ADL_P_LP5_2:" will never happen?
From K&R C: The case labeled default is executed if none of the other cases are satisfied. So no the other cases will get executed. Other C language texts suggest to put the default statement at the end of switch statements but there is no such thing in K&R C.
With BUILD_TIMELESS=1 the binary remains identical btw.
To view, visit change 66266. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9a5d39bb3cbde64f82fc90186b0f2fb64bcde595
Gerrit-Change-Number: 66266
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan@9elements.com>
Gerrit-Reviewer: Michał Kopeć <michal.kopec@3mdeb.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski@3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas@noos.fr>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Michał Żygowski <michal.zygowski@3mdeb.com>
Gerrit-Attention: Michał Kopeć <michal.kopec@3mdeb.com>
Gerrit-Attention: Elyes Haouas <ehaouas@noos.fr>
Gerrit-Comment-Date: Fri, 04 Nov 2022 18:38:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Elyes Haouas <ehaouas@noos.fr>
Gerrit-MessageType: comment