Thanks for your work on this, Wim. This is a move in the right direction, allowing us to remove the fwlib21 target. On the other hand, it just shifts our pain point to another area -- namely, now you are using vboot2 internals instead of vboot2.1 internals. That means we *still* need to keep NEED_VB20_INTERNALS around, a macro we plan to deprecate within the next month or so.

View Change

2 comments:

• File src/vendorcode/eltan/security/verified_boot/vboot_check.c:

  • Patch Set #2, Line 17: #define NEED_VB20_INTERNALS /* Peeking into vb2_shared_data */

    > Understood, the issue is that we need to have the code for this project upstreamed. […]

    Julius has made some good points here. Could we know more about where vboot falls short of covering Eltan verified boot requirements?

• File src/vendorcode/eltan/security/verified_boot/vboot_check.c:

  • Patch Set #6, Line 17: /* Peeking into vb2_shared_data */

    May as well delete this comment since that's not the only thing you're doing here.

To view, visit change 38590. To unsubscribe, or for help writing mail filters, visit settings.