2 comments:
File src/northbridge/intel/common/mchbar_ops.h:
Patch Set #37, Line 8: (u8 *)DEFAULT_MCHBAR + x)
Macro safety, please. Also, should we avoid pointer arithmetics?
#define MCHBAR8(x) (*((volatile u8 *)((void *)(DEFAULT_MCHBAR + (x)))))
Are these casts already needed to get it through Jenkins? Otherwise, we […]
The casts on `value` should never be needed. Casts on `mask` are probably meant to work around compilers complaining about overflow because of autopromotion when performing bitwise negations.
Also, `0xff`? Did you mean `UINT8_MAX`?
To view, visit change 45517. To unsubscribe, or for help writing mail filters, visit settings.