View Change
1 comment:
Commit Message:
Patch Set #1, Line 14: check GPIO86 state is PU
Understood. I was just curious if configuring the pad to drive high helps fix any observed issue.
hi Furquan, I think config this eMMC RST to PU or NC from default PD would help to prevent any concern/confusion even it's not really used . thank you!
To view, visit change 45756. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9feb826eec8a8cdad5e2bd7efcbb1dcf96185dfd
Gerrit-Change-Number: 45756
Gerrit-PatchSet: 3
Gerrit-Owner: Kevin Chiu <Kevin.Chiu@quantatw.com>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya@google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Keith Tzeng <keith.tzeng@quanta.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Tue, 29 Sep 2020 02:24:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh <furquan@google.com>
Comment-In-Reply-To: Keith Tzeng <keith.tzeng@quanta.corp-partner.google.com>
Gerrit-MessageType: comment