Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34152 )
Change subject: soc/intel: Move some PARALLEL_MP prototypes
......................................................................
Patch Set 4:
Patch Set 4:
That these share the same declaration raises a question:
Why have 6 copies of the (nearly) same code in the first place?
The same thing happens for pretty much every cpu/soc, not just the 7 here. Initialisers of struct mp_ops are split across two or more files, otherwise we would just declare the functions with static together in the same file with const initialiser of mp_ops, right?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34152
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If05ee2e44504e5511f3a7a2c5dc6e48fc16a07b2
Gerrit-Change-Number: 34152
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 10 Jul 2019 19:53:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment