Felix Held has uploaded this change for review.

View Change

device/pnp_device: improve warning/error messages

Explicitly state that the assignment is missing in the devicetree. In
the case of the warnings, the missing assignments might not be an issue.

Change-Id: Ic0b2f19496c8b4cd6340b0b8a8d0155f8ad05a43
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
---
M src/device/pnp_device.c
1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/38655/1
diff --git a/src/device/pnp_device.c b/src/device/pnp_device.c
index 81aa889..dc921e7 100644
--- a/src/device/pnp_device.c
+++ b/src/device/pnp_device.c
@@ -129,12 +129,12 @@
(resource->index != PNP_IDX_IRQ0) &&
(resource->index != PNP_IDX_IRQ1))
printk(BIOS_WARNING, "WARNING: %s %02lx %s size: "
- "0x%010llx not assigned\n", dev_path(dev),
+ "0x%010llx not assigned in devicetree\n", dev_path(dev),
resource->index, resource_type(resource),
resource->size);
else
printk(BIOS_ERR, "ERROR: %s %02lx %s size: 0x%010llx "
- "not assigned\n", dev_path(dev), resource->index,
+ "not assigned in devicetree\n", dev_path(dev), resource->index,
resource_type(resource), resource->size);
return;
}

To view, visit change 38655. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic0b2f19496c8b4cd6340b0b8a8d0155f8ad05a43
Gerrit-Change-Number: 38655
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot@felixheld.de>
Gerrit-MessageType: newchange