4 comments:
File src/soc/intel/common/block/include/intelblocks/gpio_defs.h:
Patch Set #1, Line 248: PAD_CFG_GPI_GPIO_DRIVER_SCI
Let's move this down along with PAD_CFG_GPI_IRQ_WAKE under SOC_INTEL_COMMON_BLOCK_GPIO_DUAL_ROUTE_SU […]
Done
extra tab?
Some macros have the extra indent to indicate it's a continuation line. PAD_CFG_GPI_INT for example; PAD_CFG_GPIO_DRIVER_HI_Z is a counterexample. No consistent style here :) Anyone have any opinions on which is better? I can work on a CL to clean this up.
Patch Set #1, Line 401: PAD_CFG_GPI_IRQ_WAKE
It would be good to rename this to PAD_CFG_GPI_APIC_SCI() to make it clear what it is being configur […]
Sure, I'll work on that.
Patch Set #1, Line 402: PAD_CFG_GPI_DUAL_ROUTE
While we are here, we should also get rid of SOC_INTEL_COMMON_BLOCK_GPIO_DUAL_ROUTE_SUPPORT and just […]
Done
To view, visit change 32485. To unsubscribe, or for help writing mail filters, visit settings.