Patch Set 8: Code-Review-1

(5 comments)

View Change

5 comments:

• File src/ec/51nb/51nb.c:

  • Patch Set #8, Line 23: /* Enable function 5 (PS/2 AUX) */

    looks like superio stuff and should be moved to src/superio/51nb/ […]

    I'm not sure? There's no superio on the board, just the EC, and the EC also handles PS/2. It's using the same LDN functions as the Nuvoton SuperIOs for this purpose, but I can't see any other similarities.

• File src/ec/51nb/Kconfig:

  • Patch Set #8, Line 43: 0x00200000

    is that the offset of the IFD ec region?

    No

• File src/ec/51nb/Makefile.inc:

  • Patch Set #8, Line 25: $(51NB_EC_INSERT) $(obj)/coreboot.pre \

    is the IFD ec region in use?

    No, vendor firmware doesn't use the IFD ec region.

• File src/ec/51nb/ec.h:

  • Patch Set #8, Line 20: #define SETUP_COMMAND 0x4e

    probably mainboard specific

    No, this is (as far as I can tell) specific to the EC part.

• File src/mainboard/51nb/x210/hda_verb.c:

  • Patch Set #8, Line 25:

    no need for this file. use soc/intel/common/block/hda/hda. […]

    Will do.

To view, visit change 32531. To unsubscribe, or for help writing mail filters, visit settings.