View Change
1 comment:
Patchset:
Patch Set #19:
Thanks for pushing Nico, I'll try to take a look
Tbh I wouldn't do that for each platform but keep using common code, since it handles mirroring already, where required. However, we still can clean up some stuff there. Also, that code already handles the `gen_io_dec` dt options with having mirroring where needed. Copying code from common to the SoCs will just duplicate code once again
To view, visit change 57140. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib1a7f2707e565a5651ebe438320de9597f5742c3
Gerrit-Change-Number: 57140
Gerrit-PatchSet: 19
Gerrit-Owner: Sean Rhodes <admin@starlabs.systems>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot@gmail.com>
Gerrit-CC: Andy Pont <andy.pont@sdcsystems.com>
Gerrit-CC: Michael Niewöhner <foss@mniewoehner.de>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Comment-Date: Wed, 06 Oct 2021 19:18:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-MessageType: comment