Attention is currently required from: Shelley Chen, Furquan Shaikh, Tim Wawrzynczak. Hello Shelley Chen, build bot (Jenkins), Patrick Georgi, Furquan Shaikh, Tim Wawrzynczak,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/50044
to review the following change.
Change subject: Revert "mb/google/hatch/dratini: Describe the privacy_gpio" ......................................................................
Revert "mb/google/hatch/dratini: Describe the privacy_gpio"
This reverts commit f41645c34d8b22a3d887abd56138ae794fc2dfa5.
In Dragonair, during the MP stage, one of the resistors needed for this functionality has been removed. This results in the privacy-switch not readable back by the system.
BUG=b:176847083
Change-Id: I0781f338d5ecd89fccee613fb13ea25c59385625 --- M src/mainboard/google/hatch/variants/dratini/gpio.c M src/mainboard/google/hatch/variants/dratini/overridetree.cb 2 files changed, 0 insertions(+), 15 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/50044/1
diff --git a/src/mainboard/google/hatch/variants/dratini/gpio.c b/src/mainboard/google/hatch/variants/dratini/gpio.c index f50f8f2..ccb5c05 100644 --- a/src/mainboard/google/hatch/variants/dratini/gpio.c +++ b/src/mainboard/google/hatch/variants/dratini/gpio.c @@ -16,8 +16,6 @@ PAD_NC(GPP_A19, NONE), /* C12 : FPMCU_PCH_BOOT1 */ PAD_CFG_GPO(GPP_C12, 0, DEEP), - /* D4 : Camera Privacy Status */ - PAD_CFG_GPI_INT(GPP_D4, NONE, PLTRST, EDGE_BOTH), /* F1 : NC */ PAD_NC(GPP_F1, NONE), /* F3 : MEM_STRAP_3 */ diff --git a/src/mainboard/google/hatch/variants/dratini/overridetree.cb b/src/mainboard/google/hatch/variants/dratini/overridetree.cb index 3b094a3..6ec1a48 100644 --- a/src/mainboard/google/hatch/variants/dratini/overridetree.cb +++ b/src/mainboard/google/hatch/variants/dratini/overridetree.cb @@ -69,19 +69,6 @@ register "ScsEmmcHs400Enabled" = "1"
device domain 0 on - device pci 14.0 on - chip drivers/usb/acpi - device usb 0.0 on - chip drivers/usb/acpi - # The Linux Kernel does not allow an inverted BOTH_EDGE irq - # So we need to use GpioIO() instead of GpioInt() - # https://www.kernel.org/doc/Documentation/acpi/gpio-properties.txt - register "privacy_gpio" = "ACPI_GPIO_INPUT_ACTIVE_LOW(GPP_D4)" - device usb 2.6 on end - end - end - end - end # USB xHCI device pci 15.0 on chip drivers/i2c/generic register "hid" = ""ELAN0000""