17 comments:
Once you have verified with the kernel driver, I would recommend adding all the details about what kernel driver version was used for testing, what the expectations are, etc.
File src/soc/intel/tigerlake/acpi/gpio.asl:
nit: extra blank line not required.
Patch Set #16, Line 33: GPIO_IRQ14
Along with this, you also need to set FSP param GpioIrqRoute.
Local2 = PCRB (Local0)
Local2 += PAD_CFG_BASE
This and the next match can be done in a single line?
Local2 = PCRB(Local0) + PAD_CFG_BASE + Local1 * 16
Return Local2
Patch Set #16, Line 109: /* Return (Add (Local2, Multiply (Local1, 16))) */
Commented code can be removed.
I don't think this is correct. This should just be >>
Are the braces around the and ops really required?
1 extra blank line not required.
2 extra blank lines not required.
File src/soc/intel/tigerlake/gpio.c:
.gpi_int_sts_reg_0 = GPI_INT_STS_0,
.gpi_int_en_reg_0 = GPI_INT_EN_0,
Why are these removed?
Patch Set #16, Line 197: { PMC_GPP_G, GPP_G },
Why was this removed? Is it not possible to map that to GPE?
File src/soc/intel/tigerlake/include/soc/gpio_defs.h:
#define GPI_INT_STS_0 0x100
#define GPI_INT_EN_0 0x110
I am confused. Why are these removed?
space before *
File src/soc/intel/tigerlake/include/soc/gpio_soc_defs.h:
Why is this set to 26?
Patch Set #16, Line 376: TOTAL_GPIO_COMM 5
If we are going with this, I would recommend at least having macros for the communities:
#define COMM_0 0
#define COMM_1 1
#define COMM_2 2
/* GPIO community 3 is not exposed to be used and hence is skipped. */
#define COMM_4 3
#define COMM_5 4
#define TOTAL_GPIO_COMM (COMM_5 + 1)
And then use these COMM_* macros in gpio.c as index for the various communities. This will ensure that if we switch to using COMM_3 in the future, mainboard and SoC code wouldn't break unexpectedly.
I don't think we need the pinmux settings. At best, this should be added as a separate CL if they are really required.
File src/soc/intel/tigerlake/include/soc/gpio_soc_defs.h:
Patch Set #12, Line 374: #define GPP_MLK 277
I had asked kernel team. Waiting for their reply.
Any update here?
To view, visit change 37427. To unsubscribe, or for help writing mail filters, visit settings.