Arthur Heymans has uploaded this change for review.

View Change

mb/*/{x201,ms2290}/mainboard.c: Remove superfluous ramstage code

Change-Id: I0270c50dea2a2ce6c8e6114ed708f06be9d33c0e
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
---
M src/mainboard/lenovo/x201/mainboard.c
M src/mainboard/packardbell/ms2290/mainboard.c
2 files changed, 0 insertions(+), 26 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/33141/1
diff --git a/src/mainboard/lenovo/x201/mainboard.c b/src/mainboard/lenovo/x201/mainboard.c
index 54acca3..ad878db 100644
--- a/src/mainboard/lenovo/x201/mainboard.c
+++ b/src/mainboard/lenovo/x201/mainboard.c
@@ -70,19 +70,6 @@
dev->ops->init = mainboard_init;
dev->ops->acpi_fill_ssdt_generator = fill_ssdt;

- pmbase = pci_read_config32(pcidev_on_root(0x1f, 0),
- PMBASE) & 0xff80;
-
- printk(BIOS_SPEW, " ... pmbase = 0x%04x\n", pmbase);
-
- outl(0, pmbase + SMI_EN);
-
- enable_lapic();
- pci_write_config32(pcidev_on_root(0x1f, 0), GPIO_BASE,
- DEFAULT_GPIOBASE | 1);
- pci_write_config8(pcidev_on_root(0x1f, 0), GPIO_CNTL,
- 0x10);
-
/* If we're resuming from suspend, blink suspend LED */
if (acpi_is_wakeup_s3())
ec_write(0x0c, 0xc7);
diff --git a/src/mainboard/packardbell/ms2290/mainboard.c b/src/mainboard/packardbell/ms2290/mainboard.c
index 28d3bb0..d532a48 100644
--- a/src/mainboard/packardbell/ms2290/mainboard.c
+++ b/src/mainboard/packardbell/ms2290/mainboard.c
@@ -83,19 +83,6 @@
for (i = 0; i < 256; i++)
ec_write (i, dmp[i]);

- pmbase = pci_read_config32(pcidev_on_root(0x1f, 0),
- PMBASE) & 0xff80;
-
- printk(BIOS_SPEW, " ... pmbase = 0x%04x\n", pmbase);
-
- outl(0, pmbase + SMI_EN);
-
- enable_lapic();
- pci_write_config32(pcidev_on_root(0x1f, 0), GPIO_BASE,
- DEFAULT_GPIOBASE | 1);
- pci_write_config8(pcidev_on_root(0x1f, 0), GPIO_CNTL,
- 0x10);
-
install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_INT_LVDS, GMA_INT15_PANEL_FIT_DEFAULT, GMA_INT15_BOOT_DISPLAY_LFP, 2);

/* This sneaked in here, because EasyNote has no SuperIO chip.

To view, visit change 33141. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0270c50dea2a2ce6c8e6114ed708f06be9d33c0e
Gerrit-Change-Number: 33141
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-MessageType: newchange