Felix Held submitted this change.

View Change



2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved Fred Reitberger: Looks good to me, but someone else must approve Felix Held: Looks good to me, approved
vc/amd/fsp/picasso: Bring picasso inline with other AMD SoC

In preparation to using gpp_clk_setup_common for picasso, bring enum
defined in picasso more in line with other AMD SoC.

Change-Id: I9753acdff15921c84516ec873c925f36afdd2aa3
Signed-off-by: Varshit Pandya <pandyavarshit@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80412
Reviewed-by: Fred Reitberger <reitbergerfred@gmail.com>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
---
M src/vendorcode/amd/fsp/picasso/platform_descriptors.h
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/vendorcode/amd/fsp/picasso/platform_descriptors.h b/src/vendorcode/amd/fsp/picasso/platform_descriptors.h
index 0b0de10..184db27 100644
--- a/src/vendorcode/amd/fsp/picasso/platform_descriptors.h
+++ b/src/vendorcode/amd/fsp/picasso/platform_descriptors.h
@@ -44,7 +44,7 @@
} dxio_sata_channel_type;

/* CLKREQ for PCIe type descriptors */
-typedef enum {
+enum cpm_clk_req {
CLK_DISABLE = 0x00,
CLK_REQ0,
CLK_REQ1,
@@ -56,7 +56,8 @@
CLK_REQ7,
CLK_REQ8,
CLK_REQGFX = 0x0c,
-} cpm_clk_req;
+ CLK_ENABLE = 0xff,
+};

/* PCIe link ASPM initialization */
typedef enum {

To view, visit change 80412. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9753acdff15921c84516ec873c925f36afdd2aa3
Gerrit-Change-Number: 80412
Gerrit-PatchSet: 4
Gerrit-Owner: Varshit Pandya <pandyavarshit@gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred@gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk@gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged