Minor nits, but otherwise looks fine.

Patch set 8:Code-Review -1

View Change

2 comments:

• File src/mainboard/facebook/watson/Kconfig:

  • Patch Set #8, Line 58: string

    Since this is only valid for v2, it might be cleaner to use "depends on" instead of the if condition for the default, i.e:
    depends on BOARD_FACEBOOK_WATSON_V2

• File src/mainboard/facebook/watson/Kconfig.name:

  • Patch Set #8, Line 5: : 2nd variant of Watson microserver

    no need to put a description here, "Watson_v1" and "Watson_v2" are enough to know they're different versions.

To view, visit change 40575. To unsubscribe, or for help writing mail filters, visit settings.