Attention is currently required from: Angel Pons, Patrick Rudolph.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51633 )
Change subject: device/azalia_device.c: Move valid timeout delay to Kconfig
......................................................................
Patch Set 2:
(2 comments)
File src/device/azalia_device.c:
https://review.coreboot.org/c/coreboot/+/51633/comment/b71ae042_71be119d
PS2, Line 166: * No response would imply that the code is non-operative.
that the codec is non-operative?
https://review.coreboot.org/c/coreboot/+/51633/comment/707b0c0e_6c64a37d
PS2, Line 183: stopwatch_init_usecs_expire(&sw, CONFIG_AZALIA_VALID_TIMEOUT_US);
given that we already have the "standard" 25us timeout, I guess it's better named something like AZALIA_ASSUME_HUNG_AFTER_US or something like that?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51633
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia025c3fe6813f2b1c0e3ceca686bf5f76b7bca75
Gerrit-Change-Number: 51633
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 22 Mar 2021 11:24:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment