View Change
2 comments:
Commit Message:
Patch Set #141, Line 21: falling back to PCIe virtual-wire interrupts."
Nit: Could be indented too.
Done
Patch Set #141, Line 35: - Microphone
The internal(?) microphone should be easy to test?
The internal microphone apparently uses Intel SST, which Linux may not support at the moment. I'll test with Windows when I get a chance, but for now I've put back the note that it isn't working for me even with the vendor firmware.
To view, visit change 35523. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6340116abfeb2fbd280d143b74d323e4da3566f6
Gerrit-Change-Number: 35523
Gerrit-PatchSet: 144
Gerrit-Owner: Benjamin Doron <benjamin.doron00@gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Benjamin Doron <benjamin.doron00@gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier@gmail.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Felix Singer <felixsinger@posteo.net>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-Comment-Date: Sun, 28 Jun 2020 08:21:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-MessageType: comment