The RCBA dump is a blocker, IMO. Such things make further maintenance
of the code base unnecessarily hard.
Patch set 19:Code-Review -1
1 comment:
File src/mainboard/lenovo/t410/romstage.c:
static const u32 rcba_dump3[] = {
/* 3310 */ 0x02060100, 0x0000000f, 0x01020000, 0x80000000,
/* 3320 */ 0x00000000, 0x04000000, 0x00000000, 0x00000000,
/* 3330 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
/* 3340 */ 0x000fffff, 0x00000000, 0x00000000, 0x00000000,
/* 3350 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
/* 3360 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
/* 3370 */ 0x00000000, 0x00000000, 0x7f8fdfff, 0x00000000,
/* 3380 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
/* 3390 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
/* 33a0 */ 0x00003900, 0x00000000, 0x00000000, 0x00000000,
/* 33b0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
/* 33c0 */ 0x00010000, 0x00000000, 0x00000000, 0x0001004b,
/* 33d0 */ 0x06000008, 0x00010000, 0x00000000, 0x00000000,
/* 33e0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
/* 33f0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
/* 3400 */ 0x0000001c, 0x00000080, 0x00000000, 0x00000000,
/* 3410 */ 0x00000c61, 0x00000000, 0x16e41fe1, 0xbf4f001f,
/* 3420 */ 0x00000000, 0x00060010, 0x0000000d, 0x00000000,
/* 3430 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
/* 3440 */ 0xdeaddeed, 0x00000000, 0x00000000, 0x00000000,
/* 3450 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
/* 3460 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
/* 3470 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
/* 3480 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
/* 3490 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
/* 34a0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
/* 34b0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
/* 34c0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
/* 34d0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
/* 34e0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
/* 34f0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
/* 3500 */ 0x2000055f, 0x2000055f, 0x2000074b, 0x2000014b,
/* 3510 */ 0x2000014b, 0x2000074b, 0x2000074b, 0x2000074b,
/* 3520 */ 0x2000055f, 0x2000055f, 0x2000074b, 0x2000074b,
/* 3530 */ 0x20000557, 0x2000055f, 0x00000000, 0x00000000,
/* 3540 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
/* 3550 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
/* 3560 */ 0x00000001, 0x000026a3, 0x00040002, 0x01000052,
/* 3570 */ 0x02000772, 0x16000f8f, 0x1800ff4f, 0x0001d630,
/* 3580 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
/* 3590 */ 0x00000003, 0x00000000, 0x00000000, 0x00000000,
/* 35a0 */ 0xfc000201, 0x3c000201, 0x00000000, 0x00000000,
/* 35b0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
/* 35c0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
/* 35d0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
/* 35e0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
/* 35f0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
/* 3600 */ 0x0a001f00, 0x00000000, 0x00000000, 0x00000001,
/* 3610 */ 0x00010000, 0x00000000, 0x00000000, 0x00000000,
/* 3620 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
/* 3630 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
/* 3640 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
/* 3650 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
/* 3660 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
/* 3670 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
/* 3680 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
/* 3690 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
/* 36a0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
/* 36b0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
/* 36c0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
/* 36d0 */ 0x00000000, 0x089c0018, 0x00000000, 0x00000000,
/* 36e0 */ 0x11111111, 0x00000000, 0x00000000, 0x00000000,
/* 36f0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
/* 3700 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000,
};
seems to boot without the replay.
Where does it come from? copy-paste? fresh for this board?
I don't consider ports with such replays mergable...
To view, visit change 11791. To unsubscribe, or for help writing mail filters, visit settings.