Patch Set #13, Line 9:
To make it easier to pop arguments from stack use size_t instead of int.
There's a lot of assumptions in this sentence and no comments in the code. I assume you are thinking postcar is being ran from x86-64 mode as well as the stage that is pushing values? Just changing things to size_t doesn't seem appropriate. I'd like to see an analysis of the source and destination ISA you and what you think the stack frame should look like. e.g. 64 bit values like msrs can pushed as one value. I don't think we should just be changing the type to size_t in the push helper. You might want to break things up that will push 64-bit values as well as size values you are wanting to target.
To view, visit change 32375. To unsubscribe, or for help writing mail filters, visit settings.