Patch Set 2: Code-Review-1

Since there are "Switch away from ROMCC_BOOTBLOCK" changes for the following boards, which most likely are working and we spent a lot of time on them, these boards should not be dropped:

CB:37751 - amd/inagua
CB:37978 - amd/olivehill
CB:37744 - amd/parmer
CB:37752 - amd/persimmon
CB:37748 - amd/south_station
CB:37743 - amd/thatcher
CB:37749 - amd/union_station
CB:37975 - bap/ode_e20XX
CB:37872 - biostar/a68n_5200
CB:37747 - elmex/pcm20540*
CB:37869 - gizmosphere/gizmo2
CB:37977 - hp/abm
CB:37750 - jetway/nf81-t56n-lf
CB:37745 - lippert/frontrunner-af
CB:37746 - lippert/toucan-af

Especially biostar/a68n_5200 (CB:37872), gizmosphere/gizmo2 (CB:37869) and jetway/nf81-t56n-lf (CB:37750) shouldn't be dropped, since these boards are significantly more common and available than the other expensive&rare devboards.

However, it's okay to drop the boards which seem to be really broken (switching away from ROMCC_BOOTBLOCK is not enough)

amd/bettong
amd/db-ft3b-lc
amd/lamar
amd/olivehillplus
bap/ode_e21XX

all of those boards are not unmaintained and not tested ...

Your -1 (or even -2) is ok, so why those uploads/rebase ?

View Change

To view, visit change 37997. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If129044a44df364a55d10a56e9a678212516ed8a
Gerrit-Change-Number: 37997
Gerrit-PatchSet: 5
Gerrit-Owner: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: Jacob Garber <jgarber1@ualberta.ca>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski@3mdeb.com>
Gerrit-Reviewer: Mike Banon <mikebdp2@gmail.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Piotr Król <piotr.krol@3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Wed, 01 Jan 2020 22:14:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment