Attention is currently required from: Arthur Heymans, Christian Walter, Felix Held, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Shuo Liu, Tim Chu.
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
8 comments:
Patchset:
I wanted to give this more thought, but seeing superficial reviews
(which I blame for the accumulated days of unnecessary work on this
topic) again, put me into damage-control mode. Where I'll stay for
a while.
File src/soc/intel/xeon_sp/acpi/iiostack.asl:
Patch Set #2, Line 75: CreateDWordField (Local7, Zero, QSUP)
I fail to find any use of this.
Patch Set #2, Line 87: (OscArg0 == ToUUID (CXL_HOST_BRIDGE_OSC_UUID)))
Doesn't this need an `IsCxlDomain != 0` too?
3?
Patch Set #2, Line 99: ToInteger
Isn't a DWord an Integer already?
Patch Set #2, Line 100: Local1 = GrantedPCIeFeatures
Is it actually necessary to use local variables for this?
What is SUPL?
5?
To view, visit change 82034. To unsubscribe, or for help writing mail filters, visit settings.