Patch Set 6:

When you want to make such changes to general tree topology, please announce your ideas on the mailing list first. Some things are wired in strange ways and hooked up into automatic generation of tables that used to be presented in the (now obsoleted) wiki.

There is rarely the need to have something tied to "mainboard vendor". These things usually end up being so generic others will want them too, making mb/intel/common somewhat awkward to use. I need to say I did not do thorough review of this, but I am speculating drivers/ might suite us better.

Or even a library in vendorcode? If it really is just related to intel mainboards, why a lib in vendorcode can't serve the needs?

View Change

To view, visit change 37705. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idc6f9bd298520f5e929534c64f1b038a4c9684a9
Gerrit-Change-Number: 37705
Gerrit-PatchSet: 6
Gerrit-Owner: Aamir Bohra <aamir.bohra@intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra@intel.com>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub@google.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela@intel.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi@intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: V Sowmya <v.sowmya@intel.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh@siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Thu, 19 Dec 2019 05:49:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment