9 comments:
Patch Set #24, Line 7: h110m-e_m2
very minor nit: this can be the pretty name:
Add ASUS H110M-E M/2 mainboard
(note that "support" has been omitted, as it's clear enough)
File src/mainboard/asus/h110m-e_m2/Makefile.inc:
You can remove this
File src/mainboard/asus/h110m-e_m2/acpi/superio.asl:
Maybe this needs an update.
File src/mainboard/asus/h110m-e_m2/devicetree.cb:
.psi2threshold = 0x10, \
.psi3threshold = 0x4, \
These can use VR_CFG_AMP too, see table above, column "SA"
.psi1threshold = 0x50, \
.psi2threshold = 0x14, \
.psi3threshold = 0x4, \
same VR_CFG_AMP thing, row is "IA"
.psi1threshold = 0x50, \
.psi2threshold = 0x14, \
.psi3threshold = 0x4, \
same, "GT unsliced"
.psi1threshold = 0x50, \
.psi2threshold = 0x14, \
.psi3threshold = 0x4, \
same, "GT"
Patch Set #24, Line 253: subsystemid 0x1043 0x8694 inherit
move to the previous line, before "device pci 00.0 on"
these stale "end" could be moved on the previous line
To view, visit change 34603. To unsubscribe, or for help writing mail filters, visit settings.