Patch Set 4:

have you verified that this won't impact audio? this gets enabled in the acp initialization and it has some comment that this is internally routed to the I2S block

LTE sku will have external clock source chip. Please refer the issue.

View Change

2 comments:

To view, visit change 48556. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ida747938373f648524b1e7f34bc69e372a69c4f9
Gerrit-Change-Number: 48556
Gerrit-PatchSet: 4
Gerrit-Owner: John Su <john_su@compal.corp-partner.google.com>
Gerrit-Reviewer: EricR Lai <ericr_lai@compal.corp-partner.google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Kangheui Won <khwon@chromium.org>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd@gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Rob Barnes <robbarnes@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Reviewer: chris wang <Chris.Wang@amd.com>
Gerrit-CC: Alan Lee <alan_lee@compal.corp-partner.google.com>
Gerrit-CC: Amanda Hwang <amanda_hwang@compal.corp-partner.google.com>
Gerrit-CC: Dtrain Hsu <dtrain_hsu@compal.corp-partner.google.com>
Gerrit-CC: Frank Wu <frank_wu@compal.corp-partner.google.com>
Gerrit-CC: Ian Feng <ian_feng@compal.corp-partner.google.com>
Gerrit-CC: Ivy Jian <ivy_jian@compal.corp-partner.google.com>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Comment-Date: Mon, 14 Dec 2020 16:08:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki <kyosti.malkki@gmail.com>
Comment-In-Reply-To: EricR Lai <ericr_lai@compal.corp-partner.google.com>
Gerrit-MessageType: comment