1 comment:
Patch Set #4, Line 11: renamed
Can you explain why you explicitly went with the prefix XXX as opposed to SOC in the implementation?
I made the following comment somewhere in baytrail:
The prefix XXX_ is arbitrary. Would SCH_ or PCH_ be somewhat correct?
Later intels use SA_ and PCH_ prefixes.
AMD does this:
#if !defined(__SIMPLE_DEVICE__
#include <device/device.h>
#define _SOC_DEV(slot, func) pcidev_on_root(slot, func)
#else
#define _SOC_DEV(slot, func) PCI_DEV(0, slot, func)
#endif
#define GNB_DEV 0x0
#define GNB_FUNC 0
#define GNB_DEVID 0x1576
#define GNB_DEVFN PCI_DEVFN(GNB_DEV, GNB_FUNC)
#define SOC_GNB_DEV _SOC_DEV(GNB_DEV, GNB_FUNC)
So.. prefix SOC_ there is conversion to either struct device or PCI_DEV(0,d,f).
To view, visit change 35730. To unsubscribe, or for help writing mail filters, visit settings.