4 comments:
File Documentation/drivers/smmstorev2.md:
Patch Set #21, Line 1: # SMM based flash storage driver Version 2
really outstanding job here
File src/drivers/smmstore/Kconfig:
Patch Set #21, Line 12: default y if PAYLOAD_TIANOCORE
I feel that Y isn't the best default at the present time, since neither the default Tianocore package (my fork of CorebootPayloadPkg), nor upstream edk2 (the default for UefipayloadPkg) currently support it. And 9elements' current sample implementation fails to boot on older platforms. We should default to N until there is a reasonably-well working implementation that is selectable via Tianocore's Kconfig, and probably add 'depends on !TIANOCORE_COREBOOTPAYLOAD' as well to be safe
File src/drivers/smmstore/smi.c:
Patch Set #21, Line 144: usually
usually? are there conditions under which these are not true?
Patch Set #21, Line 43: * FIXME: The data format isn't specified.
is this needed?
To view, visit change 40520. To unsubscribe, or for help writing mail filters, visit settings.