Attention is currently required from: Appukuttan V K, Arthur Heymans, Krishna P Bhat D, Subrata Banik, Wonkyu Kim.
1 comment:
File src/drivers/intel/fsp2_0/memory_init.c:
Patch Set #6, Line 37: static uint8_t temp_ram[CONFIG_FSP_TEMP_RAM_SIZE] __aligned(16);
Reverted to original version to keep 32bit compatibility
i'd align the stack to 16 bytes in all cases just to be on the safe side and not have different cases here. if i don't misremember that, also when using SSE or AVX instructions, the stack frame should be 16 byte aligned anyway; no matter if in 32 or 64 bit mode. there's also no real downside to using a stricter stack alignment that necessary, so i'd just change this to 16 bytes in all cases, since something being 16 byte aligned implies that it's also 4 byte aligned
To view, visit change 81661. To unsubscribe, or for help writing mail filters, visit settings.