Attention is currently required from: Benjamin Doron, Angel Pons.
View Change
1 comment:
Commit Message:
Patch Set #9, Line 7: PEG
PEG usually refers to the PCIe root port that is directly attached to the CPU (PCI device 00:01.0). If this is actually for the PCIe root ports on the PCH, I would be against calling it "PEG" to avoid confusion.
What would you prefer? Note that this attempts to handle both situations, although I cannot test CPU PEG.
Note that SKL-U, SKL-Y and friends (e.g. KBL) do not have the PEG PCI devices (00:01.0) at all.
(FWIW, note that PEG can be bifurcated, in which case additional PCI functions 1 and 2 can be present for PEG)
Would a dGPU have function 2? I am aware that an HDA controller at function 1 is sometimes present.
To view, visit change 40625. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I107bd5f7c192b8ffc83de6d8f1ac314bb5dcbfbd
Gerrit-Change-Number: 40625
Gerrit-PatchSet: 15
Gerrit-Owner: Benjamin Doron <benjamin.doron00@gmail.com>
Gerrit-Reviewer: Benjamin Doron <benjamin.doron00@gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Attention: Benjamin Doron <benjamin.doron00@gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Comment-Date: Sun, 10 Jan 2021 17:40:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: comment