3 comments:
Patch Set #4, Line 19: value from a 'struct device *'.
Trying to read this without the OOB communication of the
past days in mind: We should somehow mention that this
applies to multiple writes to the same device.
File src/include/device/pci_mmio_cfg.h:
Doesn't the same apply to `arch/mmio.h`?
Just wondering if that's not the better place. And we could
use readxx()/writexx() below.
In any case, it doesn't seem very obvious why we have that
union. So I'd expect a comment here with the same reasoning
as in the commit message.
Wait... do we need the union? I would assume now, that a
struct, e.g. `struct pci8 { uint8_t reg[4096]; };` would
produce the same result. I wouldn't have a preference,
though.
Patch Set #4, Line 31: extern u8 *const pci_mmconf;
Adding this variable seems unrelated now (not covered by
the commit message any more). Maybe make it two changes?
To view, visit change 31752. To unsubscribe, or for help writing mail filters, visit settings.