Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33917 )
Change subject: mb/asus/am1i-a/buildOpts.c: add includes for adjusting RAM timings
......................................................................
Patch Set 8:
Patch Set 6:
Patch Set 6:
Same SHA256 when built with "make BUILD_TIMELESS=1" - probably because I didn't use anything from these includes yet.
Maybe include them in the patch that uses them?
Would be nice to have these includes already in place, also considering that the other boards like G505S have them.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33917
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I782f76119c5ce9a3cc4bc07596d27dd42b615b6d
Gerrit-Change-Number: 33917
Gerrit-PatchSet: 8
Gerrit-Owner: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 11 Apr 2020 07:35:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment