4 comments:
File src/soc/intel/xeon_sp/cpx/fsp.c:
union {
uint32_t val;
struct {
uint8_t bld_num;
uint8_t revision;
uint8_t minor;
uint8_t major;
} rev;
} revision;
this is duplicate code and should be defined in fsp/util.h. It is used in fsp/util.c and should be updated there as well.
Patch Set #1, Line 19: spec_version
How about do the shift in the preprocessor and have a single check for major and minor version.
#define CPX_SPEC_VER ...
if (hdr->spec_version != CPX_SPEC_VERSION) {
print...
mismatch...
}
You can probably do similar for the checks below. It is easy to see what is wrong when it is printed.
Print out the version.
File src/vendorcode/intel/fsp/fsp2_0/cooperlake_sp/FspmUpd.h:
Patch Set #1, Line 73: #define CPX_REV_BUILD 45
Instead of: […]
This should go in a new file version.h and have an explanation on the version scheme for this fsp.
To view, visit change 47560. To unsubscribe, or for help writing mail filters, visit settings.