Patrick Georgi submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved
Helios: Update DPTF settings for smooth fan speed control

Update DPTF settings for smooth fan speed control.

BRANCH=firmware-hatch-12672.B
BUG=b:154074920
TEST=Built and test on Helios system

Change-Id: I3f4d9fd9e17541dd5fb7982a8b43a039c41cba87
Signed-off-by: Sumeet R Pawnikar <sumeet.r.pawnikar@intel.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/40530
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
---
M src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl
1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl b/src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl
index cf2d999..39d50c3 100644
--- a/src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl
+++ b/src/mainboard/google/hatch/variants/helios/include/variant/acpi/dptf.asl
@@ -13,9 +13,12 @@
#define DPTF_TSR1_SENSOR_NAME "5V Regulator"
#define DPTF_TSR1_PASSIVE 0
#define DPTF_TSR1_CRITICAL 70
-#define DPTF_TSR1_ACTIVE_AC0 42
-#define DPTF_TSR1_ACTIVE_AC1 41
-#define DPTF_TSR1_ACTIVE_AC2 39
+#define DPTF_TSR1_ACTIVE_AC0 43
+#define DPTF_TSR1_ACTIVE_AC1 42
+#define DPTF_TSR1_ACTIVE_AC2 41
+#define DPTF_TSR1_ACTIVE_AC3 40
+#define DPTF_TSR1_ACTIVE_AC4 39
+#define DPTF_TSR1_ACTIVE_AC5 38

#define DPTF_TSR2_SENSOR_ID 2
#define DPTF_TSR2_SENSOR_NAME "Ambient"
@@ -73,7 +76,7 @@
0, 0, 0
},
Package () {
- \_SB.DPTF.TFN1, \_SB.DPTF.TSR1, 100, 90, 70, 50, 0, 0, 0, 0,
+ \_SB.DPTF.TFN1, \_SB.DPTF.TSR1, 100, 90, 70, 60, 50, 40, 30, 0,
0, 0, 0
},
Package () {

To view, visit change 40530. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3f4d9fd9e17541dd5fb7982a8b43a039c41cba87
Gerrit-Change-Number: 40530
Gerrit-PatchSet: 2
Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar@intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Kane Chen <kane_chen@pegatron.corp-partner.google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Puthikorn Voravootivat <puthik@chromium.org>
Gerrit-Reviewer: Shelley Chen <shchen@google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Hank Lin <hank2_lin@pegatron.corp-partner.google.com>
Gerrit-CC: Ken Lu <ken_lu@pegatron.corp-partner.google.com>
Gerrit-CC: Philip Chen <philipchen@chromium.org>
Gerrit-CC: Todd Broch <tbroch@chromium.org>
Gerrit-MessageType: merged