This implements nothing of the special recovery-mode behavior we discussed (both not using the cache at all in recovery mode, and erasing the cache when the retrain switch is hit). Can you please add those as well?

View Change

4 comments:

• File src/soc/qualcomm/common/include/soc/qclib_common.h:

  • Patch Set #1, Line 14: #define QCLIB_FR_DDR_TRAINING_DATA "RW_MRC_CACHE"

    Shouldn't be needed at all anymore?

• File src/soc/qualcomm/common/qclib.c:

  • Patch Set #1, Line 14: #include <mrc_cache.h>

    nit: please alphabetize above "soc"

  • Patch Set #1, Line 75: 0

    Probably a good idea to define a macro for the version, even if we're probably not going to ever change it.

  • Patch Set #1, Line 132: mrc_cache_load_current(MRC_TRAINING_DATA, 0, _ddr_training,

    Still need to check return value, right?

To view, visit change 46111. To unsubscribe, or for help writing mail filters, visit settings.