Attention is currently required from: Henry Sun, Chen Wisley, Aseda Aboagye, Karthik Ramasubramanian.
Wisley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56829 )
Change subject: mb/google/dedede/variants/haboki: add discrete TPM in overridetree
......................................................................
Patch Set 2:
(2 comments)
File src/mainboard/google/dedede/variants/haboki/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/56829/comment/74c6834a_83f5fa3f
PS1, Line 21: .gspi[0] = {
: .speed_mhz = 1,
: .early_init = 1,
: },
Can be removed.
Done
https://review.coreboot.org/c/coreboot/+/56829/comment/f23484d6_33bcaf19
PS1, Line 41:
register "SerialIoGSpiMode[PchSerialIoIndexGSPI0]" = "PchSerialIoDisabled" # Disable GSPI0 […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56829
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I08f2a562c3f62c60402350151ea260b70890a744
Gerrit-Change-Number: 56829
Gerrit-PatchSet: 2
Gerrit-Owner: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Reviewer: Aseda Aboagye
aaboagye@google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Attention: Aseda Aboagye
aaboagye@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Fri, 06 Aug 2021 08:26:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment