5 comments:
Patch Set #1, Line 9: This change adds support for
nit: just "Add"?
Done
Patch Set #1, Line 172: Limit beyond which the stolen memory cannot grow
so an upper bound for the memory range to reserve?
Done
If it is not possible to fulfill the request as per given constraints, this function returns
* false. Else, it sets the base address of stolen memory in stolen_base, creates a hole of
* required size at the stolen_base and returns true to indicate success
I think it's better to state the successful case first. […]
Done
if (size == 0) return NULL; otherwise memranges_steal() with a computed size==0 leads to weird artif […]
Done
Patch Set #1, Line 403: base = ALIGN_UP(r->begin, align);
do you intend to use the new memrange align attribute for comparison, too? if (!IS_ALIGNED(align, r- […]
Done. Add it before the loop since each range entry does not have a separate alignment. It is applicable to entire list of ranges.
To view, visit change 39484. To unsubscribe, or for help writing mail filters, visit settings.