Patrick Georgi submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved
src: Remove unused 'include <types.h>'

Files found using:
diff <(git grep -l '#include <types.h>' -- src/) <(git grep -l 'BIT(\|size_t\|wchar_t\|wint_t\|NULL\|DEVTREE_EARLY\|DEVTREE_CONST\|MAYBE_STATIC_NONZERO\|zeroptr\|int8_t\|int16_t\|int32_t\|int64_t\|intptr_t\|intmax_t\|s8\|u8\|s16\|u16\|s32\|u32\|s64\|u64\|INT8_MIN\|INT8_MAX\|INT16_MIN\|INT16_MAX\|INT32_MIN\|INT32_MAX\|INT64_MIN\|INT64_MAX\|INTMAX_MIN\|INTMAX_MAX\|bool\|true\|false\|cb_err\|CB_SUCCESS\|CB_ERR\|CB_ERR_ARG\|CB_CMOS_\|CB_KBD_\|CB_I2C_\|cb_err_t\|DIV_ROUND_CLOSEST\|container_of\|__unused\|alloca(\|ARRAY_SIZE\|ALIGN\|ALIGN_UP\|ALIGN_DOWN\|IS_ALIGNED\|__CMP_UNSAFE\|MIN_UNSAFE\|MAX_UNSAFE\|__CMP_SAFE\|__CMP\|MIN(\|MAX(\|ABS(\|IS_POWER_OF_2\|POWER_OF_2\|DIV_ROUND_UP\|SWAP(\|KiB\|MiB\|GiB\|KHz\|MHz\|GHz\|offsetof(\|check_member\|member_size' -- src/)|grep -v vendor |grep '<'

Change-Id: I5d99d844cc58d80acb505d98da9d3ec76319b2eb
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/41677
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M src/acpi/chromeos-gnvs.c
M src/arch/arm/include/armv7.h
M src/cpu/intel/model_206ax/common.c
M src/drivers/i2c/at24rf08c/at24rf08c.c
M src/drivers/lenovo/hybrid_graphics/hybrid_graphics.c
M src/drivers/tpm/tpm.c
M src/lib/trace.c
M src/mainboard/emulation/qemu-i440fx/acpi_tables.c
M src/mainboard/getac/p470/acpi_tables.c
M src/mainboard/google/auron/ec.c
M src/mainboard/google/beltino/acpi_tables.c
M src/mainboard/google/beltino/mainboard.c
M src/mainboard/google/beltino/variants/mccloud/led.c
M src/mainboard/google/beltino/variants/monroe/led.c
M src/mainboard/google/beltino/variants/panther/led.c
M src/mainboard/google/beltino/variants/tricky/led.c
M src/mainboard/google/beltino/variants/zako/led.c
M src/mainboard/google/cyan/ec.c
M src/mainboard/google/daisy/romstage.c
M src/mainboard/google/gale/cdp.c
M src/mainboard/google/jecht/acpi_tables.c
M src/mainboard/google/jecht/led.c
M src/mainboard/google/link/ec.c
M src/mainboard/google/parrot/acpi_tables.c
M src/mainboard/google/rambi/acpi_tables.c
M src/mainboard/google/rambi/ec.c
M src/mainboard/google/rambi/mainboard.c
M src/mainboard/google/slippy/acpi_tables.c
M src/mainboard/google/slippy/ec.c
M src/mainboard/google/slippy/mainboard.c
M src/mainboard/google/stout/acpi_tables.c
M src/mainboard/google/stout/mainboard.c
M src/mainboard/intel/baskingridge/acpi_tables.c
M src/mainboard/intel/baskingridge/mainboard.c
M src/mainboard/intel/emeraldlake2/acpi_tables.c
M src/mainboard/intel/emeraldlake2/ec.c
M src/mainboard/intel/emeraldlake2/mainboard.c
M src/mainboard/intel/harcuvar/acpi_tables.c
M src/mainboard/intel/strago/acpi_tables.c
M src/mainboard/intel/strago/ec.c
M src/mainboard/intel/wtm2/acpi_tables.c
M src/mainboard/intel/wtm2/mainboard.c
M src/mainboard/samsung/lumpy/acpi_tables.c
M src/mainboard/samsung/lumpy/ec.c
M src/mainboard/samsung/stumpy/acpi_tables.c
M src/mainboard/scaleway/tagada/acpi_tables.c
M src/mainboard/ti/beaglebone/bootblock.c
M src/northbridge/intel/sandybridge/common.c
M src/northbridge/intel/x4x/gma.c
M src/soc/cavium/cn81xx/include/soc/twsi.h
M src/soc/intel/common/vbt.h
M src/soc/qualcomm/qcs405/include/soc/symbols.h
M src/soc/qualcomm/sc7180/uart_bitbang.c
M src/soc/qualcomm/sdm845/uart_bitbang.c
M src/southbridge/intel/lynxpoint/acpi.c
55 files changed, 1 insertion(+), 55 deletions(-)

diff --git a/src/acpi/chromeos-gnvs.c b/src/acpi/chromeos-gnvs.c
index d30e204..4bcf892 100644
--- a/src/acpi/chromeos-gnvs.c
+++ b/src/acpi/chromeos-gnvs.c
@@ -1,7 +1,6 @@
/* SPDX-License-Identifier: GPL-2.0-only */

#include <acpi/acpi_gnvs.h>
-#include <types.h>
#include <ec/google/chromeec/ec.h>
#include <vendorcode/google/chromeos/gnvs.h>

diff --git a/src/arch/arm/include/armv7.h b/src/arch/arm/include/armv7.h
index 1223d9b..0d7a8cf 100644
--- a/src/arch/arm/include/armv7.h
+++ b/src/arch/arm/include/armv7.h
@@ -2,7 +2,6 @@

#ifndef ARMV7_H
#define ARMV7_H
-#include <types.h>

/* Cortex-A9 revisions */
#define MIDR_CORTEX_A9_R0P1 0x410FC091
diff --git a/src/cpu/intel/model_206ax/common.c b/src/cpu/intel/model_206ax/common.c
index 216160b..a881314 100644
--- a/src/cpu/intel/model_206ax/common.c
+++ b/src/cpu/intel/model_206ax/common.c
@@ -1,6 +1,5 @@
/* SPDX-License-Identifier: GPL-2.0-only */

-#include <types.h>
#include <cpu/x86/msr.h>
#include "model_206ax.h"

diff --git a/src/drivers/i2c/at24rf08c/at24rf08c.c b/src/drivers/i2c/at24rf08c/at24rf08c.c
index 22b825b..ce6aa86 100644
--- a/src/drivers/i2c/at24rf08c/at24rf08c.c
+++ b/src/drivers/i2c/at24rf08c/at24rf08c.c
@@ -1,6 +1,5 @@
/* SPDX-License-Identifier: GPL-2.0-only */

-#include <types.h>
#include <device/device.h>
#include <device/smbus.h>
#include <console/console.h>
diff --git a/src/drivers/lenovo/hybrid_graphics/hybrid_graphics.c b/src/drivers/lenovo/hybrid_graphics/hybrid_graphics.c
index ec9f995..8f0e7bd 100644
--- a/src/drivers/lenovo/hybrid_graphics/hybrid_graphics.c
+++ b/src/drivers/lenovo/hybrid_graphics/hybrid_graphics.c
@@ -1,6 +1,5 @@
/* SPDX-License-Identifier: GPL-2.0-only */

-#include <types.h>
#include <option.h>
#include <device/device.h>

diff --git a/src/drivers/tpm/tpm.c b/src/drivers/tpm/tpm.c
index f9f9c48..ce1a2b7 100644
--- a/src/drivers/tpm/tpm.c
+++ b/src/drivers/tpm/tpm.c
@@ -1,7 +1,6 @@
/* SPDX-License-Identifier: GPL-2.0-only */

#include <acpi/acpi.h>
-#include <types.h>
#include <bootstate.h>
#include <security/tpm/tspi.h>

diff --git a/src/lib/trace.c b/src/lib/trace.c
index d4c014d..a3db40b 100644
--- a/src/lib/trace.c
+++ b/src/lib/trace.c
@@ -1,6 +1,5 @@
/* SPDX-License-Identifier: GPL-2.0-only */

-#include <types.h>
#include <console/console.h>
#include <trace.h>

diff --git a/src/mainboard/emulation/qemu-i440fx/acpi_tables.c b/src/mainboard/emulation/qemu-i440fx/acpi_tables.c
index c78de52..1f10837 100644
--- a/src/mainboard/emulation/qemu-i440fx/acpi_tables.c
+++ b/src/mainboard/emulation/qemu-i440fx/acpi_tables.c
@@ -1,6 +1,5 @@
/* SPDX-License-Identifier: GPL-2.0-only */

-#include <types.h>
#include <acpi/acpi.h>
#include <arch/ioapic.h>
#include <arch/smp/mpspec.h>
diff --git a/src/mainboard/getac/p470/acpi_tables.c b/src/mainboard/getac/p470/acpi_tables.c
index d555c10..b5b5223 100644
--- a/src/mainboard/getac/p470/acpi_tables.c
+++ b/src/mainboard/getac/p470/acpi_tables.c
@@ -1,6 +1,5 @@
/* SPDX-License-Identifier: GPL-2.0-only */

-#include <types.h>
#include <string.h>
#include <console/console.h>
#include <acpi/acpi.h>
diff --git a/src/mainboard/google/auron/ec.c b/src/mainboard/google/auron/ec.c
index 8448358..5be20c0 100644
--- a/src/mainboard/google/auron/ec.c
+++ b/src/mainboard/google/auron/ec.c
@@ -2,7 +2,6 @@

#include <acpi/acpi.h>
#include <vendorcode/google/chromeos/chromeos.h>
-#include <types.h>
#include <console/console.h>
#include <ec/google/chromeec/ec.h>
#include "ec.h"
diff --git a/src/mainboard/google/beltino/acpi_tables.c b/src/mainboard/google/beltino/acpi_tables.c
index a34a1e9..9756695 100644
--- a/src/mainboard/google/beltino/acpi_tables.c
+++ b/src/mainboard/google/beltino/acpi_tables.c
@@ -1,6 +1,5 @@
/* SPDX-License-Identifier: GPL-2.0-only */

-#include <types.h>
#include <acpi/acpi.h>
#include <acpi/acpi_gnvs.h>
#include <device/device.h>
diff --git a/src/mainboard/google/beltino/mainboard.c b/src/mainboard/google/beltino/mainboard.c
index 4c2b306..e87f4314 100644
--- a/src/mainboard/google/beltino/mainboard.c
+++ b/src/mainboard/google/beltino/mainboard.c
@@ -1,6 +1,5 @@
/* SPDX-License-Identifier: GPL-2.0-only */

-#include <types.h>
#include <acpi/acpi.h>
#include <cpu/x86/smm.h>
#include <device/device.h>
diff --git a/src/mainboard/google/beltino/variants/mccloud/led.c b/src/mainboard/google/beltino/variants/mccloud/led.c
index 2ba84d9..da5002f 100644
--- a/src/mainboard/google/beltino/variants/mccloud/led.c
+++ b/src/mainboard/google/beltino/variants/mccloud/led.c
@@ -1,6 +1,5 @@
/* SPDX-License-Identifier: GPL-2.0-only */

-#include <types.h>
#include <superio/ite/it8772f/it8772f.h>
#include "../../onboard.h"

diff --git a/src/mainboard/google/beltino/variants/monroe/led.c b/src/mainboard/google/beltino/variants/monroe/led.c
index c67632f..5f6932d 100644
--- a/src/mainboard/google/beltino/variants/monroe/led.c
+++ b/src/mainboard/google/beltino/variants/monroe/led.c
@@ -1,6 +1,5 @@
/* SPDX-License-Identifier: GPL-2.0-only */

-#include <types.h>
#include "../../onboard.h"

void set_power_led(int state)
diff --git a/src/mainboard/google/beltino/variants/panther/led.c b/src/mainboard/google/beltino/variants/panther/led.c
index 54e4458..3fe93b4 100644
--- a/src/mainboard/google/beltino/variants/panther/led.c
+++ b/src/mainboard/google/beltino/variants/panther/led.c
@@ -1,6 +1,5 @@
/* SPDX-License-Identifier: GPL-2.0-only */

-#include <types.h>
#include "../../onboard.h"

void set_power_led(int state)
diff --git a/src/mainboard/google/beltino/variants/tricky/led.c b/src/mainboard/google/beltino/variants/tricky/led.c
index 475e4b6..49d7918 100644
--- a/src/mainboard/google/beltino/variants/tricky/led.c
+++ b/src/mainboard/google/beltino/variants/tricky/led.c
@@ -1,6 +1,5 @@
/* SPDX-License-Identifier: GPL-2.0-only */

-#include <types.h>
#include <superio/ite/it8772f/it8772f.h>
#include "../../onboard.h"

diff --git a/src/mainboard/google/beltino/variants/zako/led.c b/src/mainboard/google/beltino/variants/zako/led.c
index 16c0d9f..0c83657 100644
--- a/src/mainboard/google/beltino/variants/zako/led.c
+++ b/src/mainboard/google/beltino/variants/zako/led.c
@@ -1,6 +1,5 @@
/* SPDX-License-Identifier: GPL-2.0-only */

-#include <types.h>
#include "../../onboard.h"

void set_power_led(int state)
diff --git a/src/mainboard/google/cyan/ec.c b/src/mainboard/google/cyan/ec.c
index 912ae56..fa23e9f 100644
--- a/src/mainboard/google/cyan/ec.c
+++ b/src/mainboard/google/cyan/ec.c
@@ -5,7 +5,6 @@
#include <ec/google/chromeec/ec.h>
#include "ec.h"
#include <vendorcode/google/chromeos/chromeos.h>
-#include <types.h>

void mainboard_ec_init(void)
{
diff --git a/src/mainboard/google/daisy/romstage.c b/src/mainboard/google/daisy/romstage.c
index c70716a..b8105fd 100644
--- a/src/mainboard/google/daisy/romstage.c
+++ b/src/mainboard/google/daisy/romstage.c
@@ -18,7 +18,6 @@
#include <soc/trustzone.h>
#include <soc/wakeup.h>
#include <timestamp.h>
-#include <types.h>

#include "exynos5250.h"

diff --git a/src/mainboard/google/gale/cdp.c b/src/mainboard/google/gale/cdp.c
index 1ac44fa..ab7bc8c 100644
--- a/src/mainboard/google/gale/cdp.c
+++ b/src/mainboard/google/gale/cdp.c
@@ -4,7 +4,6 @@
#include <soc/cdp.h>
#include <soc/ebi2.h>
#include <soc/clock.h>
-#include <types.h>
#include <boardid.h>

void ipq_configure_gpio(const gpio_func_data_t *gpio, unsigned int count)
diff --git a/src/mainboard/google/jecht/acpi_tables.c b/src/mainboard/google/jecht/acpi_tables.c
index 1b96df6..f824cd8 100644
--- a/src/mainboard/google/jecht/acpi_tables.c
+++ b/src/mainboard/google/jecht/acpi_tables.c
@@ -1,6 +1,5 @@
/* SPDX-License-Identifier: GPL-2.0-only */

-#include <types.h>
#include <acpi/acpi.h>
#include <acpi/acpi_gnvs.h>
#include <arch/ioapic.h>
diff --git a/src/mainboard/google/jecht/led.c b/src/mainboard/google/jecht/led.c
index 054f0aa..8a6a304 100644
--- a/src/mainboard/google/jecht/led.c
+++ b/src/mainboard/google/jecht/led.c
@@ -1,6 +1,5 @@
/* SPDX-License-Identifier: GPL-2.0-only */

-#include <types.h>
#include <superio/ite/it8772f/it8772f.h>
#include "onboard.h"

diff --git a/src/mainboard/google/link/ec.c b/src/mainboard/google/link/ec.c
index e3f68e1..6f87f1d 100644
--- a/src/mainboard/google/link/ec.c
+++ b/src/mainboard/google/link/ec.c
@@ -1,7 +1,6 @@
/* SPDX-License-Identifier: GPL-2.0-only */

#include <acpi/acpi.h>
-#include <types.h>
#include <console/console.h>
#include <ec/google/chromeec/ec.h>
#include "ec.h"
diff --git a/src/mainboard/google/parrot/acpi_tables.c b/src/mainboard/google/parrot/acpi_tables.c
index a4d3319..3332286 100644
--- a/src/mainboard/google/parrot/acpi_tables.c
+++ b/src/mainboard/google/parrot/acpi_tables.c
@@ -1,6 +1,5 @@
/* SPDX-License-Identifier: GPL-2.0-only */

-#include <types.h>
#include <acpi/acpi.h>
#include <acpi/acpi_gnvs.h>
#include <device/device.h>
diff --git a/src/mainboard/google/rambi/acpi_tables.c b/src/mainboard/google/rambi/acpi_tables.c
index 54735ce..a9a0885 100644
--- a/src/mainboard/google/rambi/acpi_tables.c
+++ b/src/mainboard/google/rambi/acpi_tables.c
@@ -1,6 +1,5 @@
/* SPDX-License-Identifier: GPL-2.0-only */

-#include <types.h>
#include <acpi/acpi.h>
#include <acpi/acpi_gnvs.h>
#include <arch/ioapic.h>
diff --git a/src/mainboard/google/rambi/ec.c b/src/mainboard/google/rambi/ec.c
index 0d7d110..7588eff 100644
--- a/src/mainboard/google/rambi/ec.c
+++ b/src/mainboard/google/rambi/ec.c
@@ -1,7 +1,6 @@
/* SPDX-License-Identifier: GPL-2.0-only */

#include <acpi/acpi.h>
-#include <types.h>
#include <console/console.h>
#include <ec/google/chromeec/ec.h>
#include "ec.h"
diff --git a/src/mainboard/google/rambi/mainboard.c b/src/mainboard/google/rambi/mainboard.c
index b81a037..0f729bf 100644
--- a/src/mainboard/google/rambi/mainboard.c
+++ b/src/mainboard/google/rambi/mainboard.c
@@ -1,6 +1,5 @@
/* SPDX-License-Identifier: GPL-2.0-only */

-#include <types.h>
#include <device/device.h>
#include <console/console.h>
#if CONFIG(VGA_ROM_RUN)
diff --git a/src/mainboard/google/slippy/acpi_tables.c b/src/mainboard/google/slippy/acpi_tables.c
index 28364c9..3435c28 100644
--- a/src/mainboard/google/slippy/acpi_tables.c
+++ b/src/mainboard/google/slippy/acpi_tables.c
@@ -1,6 +1,5 @@
/* SPDX-License-Identifier: GPL-2.0-only */

-#include <types.h>
#include <acpi/acpi.h>
#include <acpi/acpi_gnvs.h>
#include <device/device.h>
diff --git a/src/mainboard/google/slippy/ec.c b/src/mainboard/google/slippy/ec.c
index b646b9c..5761a7c 100644
--- a/src/mainboard/google/slippy/ec.c
+++ b/src/mainboard/google/slippy/ec.c
@@ -1,7 +1,6 @@
/* SPDX-License-Identifier: GPL-2.0-only */

#include <acpi/acpi.h>
-#include <types.h>
#include <console/console.h>
#include <ec/google/chromeec/ec.h>
#include "ec.h"
diff --git a/src/mainboard/google/slippy/mainboard.c b/src/mainboard/google/slippy/mainboard.c
index c6492ac..2a819d3 100644
--- a/src/mainboard/google/slippy/mainboard.c
+++ b/src/mainboard/google/slippy/mainboard.c
@@ -1,6 +1,5 @@
/* SPDX-License-Identifier: GPL-2.0-only */

-#include <types.h>
#include <smbios.h>
#include <cpu/x86/smm.h>
#include <device/device.h>
diff --git a/src/mainboard/google/stout/acpi_tables.c b/src/mainboard/google/stout/acpi_tables.c
index 101e8f1..27b6eca 100644
--- a/src/mainboard/google/stout/acpi_tables.c
+++ b/src/mainboard/google/stout/acpi_tables.c
@@ -1,6 +1,5 @@
/* SPDX-License-Identifier: GPL-2.0-only */

-#include <types.h>
#include <acpi/acpi.h>
#include <acpi/acpi_gnvs.h>
#include <device/device.h>
diff --git a/src/mainboard/google/stout/mainboard.c b/src/mainboard/google/stout/mainboard.c
index 2f89ef5e..29a6923 100644
--- a/src/mainboard/google/stout/mainboard.c
+++ b/src/mainboard/google/stout/mainboard.c
@@ -1,6 +1,5 @@
/* SPDX-License-Identifier: GPL-2.0-only */

-#include <types.h>
#include <device/device.h>
#include <device/pci_ops.h>
#include <drivers/intel/gma/int15.h>
diff --git a/src/mainboard/intel/baskingridge/acpi_tables.c b/src/mainboard/intel/baskingridge/acpi_tables.c
index d31735d..fe44d08 100644
--- a/src/mainboard/intel/baskingridge/acpi_tables.c
+++ b/src/mainboard/intel/baskingridge/acpi_tables.c
@@ -1,6 +1,5 @@
/* SPDX-License-Identifier: GPL-2.0-only */

-#include <types.h>
#include <acpi/acpi.h>
#include <acpi/acpi_gnvs.h>
#include <device/device.h>
diff --git a/src/mainboard/intel/baskingridge/mainboard.c b/src/mainboard/intel/baskingridge/mainboard.c
index 7111e8f..04803fa 100644
--- a/src/mainboard/intel/baskingridge/mainboard.c
+++ b/src/mainboard/intel/baskingridge/mainboard.c
@@ -1,6 +1,5 @@
/* SPDX-License-Identifier: GPL-2.0-only */

-#include <types.h>
#include <cpu/x86/smm.h>
#include <device/device.h>
#include <drivers/intel/gma/int15.h>
diff --git a/src/mainboard/intel/emeraldlake2/acpi_tables.c b/src/mainboard/intel/emeraldlake2/acpi_tables.c
index 2ae7de4..302966a 100644
--- a/src/mainboard/intel/emeraldlake2/acpi_tables.c
+++ b/src/mainboard/intel/emeraldlake2/acpi_tables.c
@@ -1,6 +1,5 @@
/* SPDX-License-Identifier: GPL-2.0-only */

-#include <types.h>
#include <acpi/acpi.h>
#include <acpi/acpi_gnvs.h>
#include <device/device.h>
diff --git a/src/mainboard/intel/emeraldlake2/ec.c b/src/mainboard/intel/emeraldlake2/ec.c
index f6819c7..5c088a3 100644
--- a/src/mainboard/intel/emeraldlake2/ec.c
+++ b/src/mainboard/intel/emeraldlake2/ec.c
@@ -1,7 +1,6 @@
/* SPDX-License-Identifier: GPL-2.0-only */

#include <acpi/acpi.h>
-#include <types.h>
#include <console/console.h>
#include <ec/smsc/mec1308/ec.h>
#include "ec.h"
diff --git a/src/mainboard/intel/emeraldlake2/mainboard.c b/src/mainboard/intel/emeraldlake2/mainboard.c
index c97face..6291d60 100644
--- a/src/mainboard/intel/emeraldlake2/mainboard.c
+++ b/src/mainboard/intel/emeraldlake2/mainboard.c
@@ -1,6 +1,5 @@
/* SPDX-License-Identifier: GPL-2.0-only */

-#include <types.h>
#include <device/device.h>
#include <drivers/intel/gma/int15.h>
#include <acpi/acpi.h>
diff --git a/src/mainboard/intel/harcuvar/acpi_tables.c b/src/mainboard/intel/harcuvar/acpi_tables.c
index cfe0caa..e91b3b0 100644
--- a/src/mainboard/intel/harcuvar/acpi_tables.c
+++ b/src/mainboard/intel/harcuvar/acpi_tables.c
@@ -1,6 +1,5 @@
/* SPDX-License-Identifier: GPL-2.0-only */

-#include <types.h>
#include <acpi/acpi.h>
#include <acpi/acpi_gnvs.h>
#include <device/device.h>
diff --git a/src/mainboard/intel/strago/acpi_tables.c b/src/mainboard/intel/strago/acpi_tables.c
index 2df0d15..25d6a37 100644
--- a/src/mainboard/intel/strago/acpi_tables.c
+++ b/src/mainboard/intel/strago/acpi_tables.c
@@ -7,7 +7,6 @@
#include <soc/acpi.h>
#include <soc/iomap.h>
#include <soc/nvs.h>
-#include <types.h>
#include <boardid.h>
#include "onboard.h"

diff --git a/src/mainboard/intel/strago/ec.c b/src/mainboard/intel/strago/ec.c
index 912ae56..fa23e9f 100644
--- a/src/mainboard/intel/strago/ec.c
+++ b/src/mainboard/intel/strago/ec.c
@@ -5,7 +5,6 @@
#include <ec/google/chromeec/ec.h>
#include "ec.h"
#include <vendorcode/google/chromeos/chromeos.h>
-#include <types.h>

void mainboard_ec_init(void)
{
diff --git a/src/mainboard/intel/wtm2/acpi_tables.c b/src/mainboard/intel/wtm2/acpi_tables.c
index 416f945..62eb09a 100644
--- a/src/mainboard/intel/wtm2/acpi_tables.c
+++ b/src/mainboard/intel/wtm2/acpi_tables.c
@@ -1,6 +1,5 @@
/* SPDX-License-Identifier: GPL-2.0-only */

-#include <types.h>
#include <acpi/acpi.h>
#include <acpi/acpi_gnvs.h>
#include <arch/ioapic.h>
diff --git a/src/mainboard/intel/wtm2/mainboard.c b/src/mainboard/intel/wtm2/mainboard.c
index c0a5764..48568cd 100644
--- a/src/mainboard/intel/wtm2/mainboard.c
+++ b/src/mainboard/intel/wtm2/mainboard.c
@@ -1,6 +1,5 @@
/* SPDX-License-Identifier: GPL-2.0-only */

-#include <types.h>
#include <cpu/x86/smm.h>
#include <device/device.h>
#include <drivers/intel/gma/int15.h>
diff --git a/src/mainboard/samsung/lumpy/acpi_tables.c b/src/mainboard/samsung/lumpy/acpi_tables.c
index e730bc2..1a3317d 100644
--- a/src/mainboard/samsung/lumpy/acpi_tables.c
+++ b/src/mainboard/samsung/lumpy/acpi_tables.c
@@ -1,6 +1,5 @@
/* SPDX-License-Identifier: GPL-2.0-only */

-#include <types.h>
#include <acpi/acpi.h>
#include <acpi/acpi_gnvs.h>
#include <device/device.h>
diff --git a/src/mainboard/samsung/lumpy/ec.c b/src/mainboard/samsung/lumpy/ec.c
index a53d033..7aac479 100644
--- a/src/mainboard/samsung/lumpy/ec.c
+++ b/src/mainboard/samsung/lumpy/ec.c
@@ -1,7 +1,6 @@
/* SPDX-License-Identifier: GPL-2.0-only */

#include <acpi/acpi.h>
-#include <types.h>
#include <console/console.h>
#include <ec/smsc/mec1308/ec.h>
#include "ec.h"
diff --git a/src/mainboard/samsung/stumpy/acpi_tables.c b/src/mainboard/samsung/stumpy/acpi_tables.c
index dcdd4e5..b2c1fca 100644
--- a/src/mainboard/samsung/stumpy/acpi_tables.c
+++ b/src/mainboard/samsung/stumpy/acpi_tables.c
@@ -1,6 +1,5 @@
/* SPDX-License-Identifier: GPL-2.0-only */

-#include <types.h>
#include <acpi/acpi.h>
#include <acpi/acpi_gnvs.h>
#include <device/device.h>
diff --git a/src/mainboard/scaleway/tagada/acpi_tables.c b/src/mainboard/scaleway/tagada/acpi_tables.c
index cfe0caa..e91b3b0 100644
--- a/src/mainboard/scaleway/tagada/acpi_tables.c
+++ b/src/mainboard/scaleway/tagada/acpi_tables.c
@@ -1,6 +1,5 @@
/* SPDX-License-Identifier: GPL-2.0-only */

-#include <types.h>
#include <acpi/acpi.h>
#include <acpi/acpi_gnvs.h>
#include <device/device.h>
diff --git a/src/mainboard/ti/beaglebone/bootblock.c b/src/mainboard/ti/beaglebone/bootblock.c
index 7e69a3d..6e9538b 100644
--- a/src/mainboard/ti/beaglebone/bootblock.c
+++ b/src/mainboard/ti/beaglebone/bootblock.c
@@ -1,7 +1,6 @@
/* SPDX-License-Identifier: GPL-2.0-only */

#include <device/mmio.h>
-#include <types.h>
#include <bootblock_common.h>
#include <console/uart.h>
#include <cpu/ti/am335x/clock.h>
diff --git a/src/northbridge/intel/sandybridge/common.c b/src/northbridge/intel/sandybridge/common.c
index d64a740..b27911d 100644
--- a/src/northbridge/intel/sandybridge/common.c
+++ b/src/northbridge/intel/sandybridge/common.c
@@ -1,6 +1,5 @@
/* SPDX-License-Identifier: GPL-2.0-only */

-#include <types.h>
#include <console/console.h>
#include <device/device.h>
#include "sandybridge.h"
diff --git a/src/northbridge/intel/x4x/gma.c b/src/northbridge/intel/x4x/gma.c
index 68d382e..03e738d 100644
--- a/src/northbridge/intel/x4x/gma.c
+++ b/src/northbridge/intel/x4x/gma.c
@@ -12,7 +12,6 @@
#include <drivers/intel/gma/opregion.h>
#include <drivers/intel/gma/libgfxinit.h>
#include <pc80/vga.h>
-#include <types.h>

#include "chip.h"
#include "drivers/intel/gma/i915_reg.h"
diff --git a/src/soc/cavium/cn81xx/include/soc/twsi.h b/src/soc/cavium/cn81xx/include/soc/twsi.h
index 9756c6a..436df57 100644
--- a/src/soc/cavium/cn81xx/include/soc/twsi.h
+++ b/src/soc/cavium/cn81xx/include/soc/twsi.h
@@ -1,5 +1,5 @@
/* SPDX-License-Identifier: GPL-2.0-only */
-#include <types.h>
+
#include <device/i2c.h>

#ifndef __SOC_CAVIUM_CN81XX_INCLUDE_SOC_TWSI_H
diff --git a/src/soc/intel/common/vbt.h b/src/soc/intel/common/vbt.h
index e5b0066..5cbb2c7 100644
--- a/src/soc/intel/common/vbt.h
+++ b/src/soc/intel/common/vbt.h
@@ -4,7 +4,6 @@
#define _INTEL_COMMON_VBT_H_

#include <commonlib/region.h>
-#include <types.h>

/*
* Returns VBT pointer and mapping after checking prerequisites for Pre OS
diff --git a/src/soc/qualcomm/qcs405/include/soc/symbols.h b/src/soc/qualcomm/qcs405/include/soc/symbols.h
index fb17102..945a85c 100644
--- a/src/soc/qualcomm/qcs405/include/soc/symbols.h
+++ b/src/soc/qualcomm/qcs405/include/soc/symbols.h
@@ -4,7 +4,6 @@
#define _SOC_QUALCOMM_QCS405_SYMBOLS_H_

#include <symbols.h>
-#include <types.h>

DECLARE_REGION(ssram);
DECLARE_REGION(bsram);
diff --git a/src/soc/qualcomm/sc7180/uart_bitbang.c b/src/soc/qualcomm/sc7180/uart_bitbang.c
index b671fec..b3a6cd5 100644
--- a/src/soc/qualcomm/sc7180/uart_bitbang.c
+++ b/src/soc/qualcomm/sc7180/uart_bitbang.c
@@ -2,7 +2,6 @@

#include <console/uart.h>
#include <gpio.h>
-#include <types.h>
#include <boot/coreboot_tables.h>

#define UART_TX_PIN GPIO(44)
diff --git a/src/soc/qualcomm/sdm845/uart_bitbang.c b/src/soc/qualcomm/sdm845/uart_bitbang.c
index 6bcc5ba..b78db83 100644
--- a/src/soc/qualcomm/sdm845/uart_bitbang.c
+++ b/src/soc/qualcomm/sdm845/uart_bitbang.c
@@ -2,7 +2,6 @@

#include <console/uart.h>
#include <gpio.h>
-#include <types.h>

#define UART_TX_PIN GPIO(4)

diff --git a/src/southbridge/intel/lynxpoint/acpi.c b/src/southbridge/intel/lynxpoint/acpi.c
index cfdcee6..995943d 100644
--- a/src/southbridge/intel/lynxpoint/acpi.c
+++ b/src/southbridge/intel/lynxpoint/acpi.c
@@ -3,7 +3,6 @@
#include <acpi/acpi.h>
#include <acpi/acpi_gnvs.h>
#include <acpi/acpigen.h>
-#include <types.h>
#include <string.h>
#include <version.h>


To view, visit change 41677. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5d99d844cc58d80acb505d98da9d3ec76319b2eb
Gerrit-Change-Number: 41677
Gerrit-PatchSet: 24
Gerrit-Owner: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: David Guckian <david.guckian@intel.com>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-MessageType: merged