[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/cannonlake: Add required FSP UPD changes for CML

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31284 )

Change subject: soc/intel/cannonlake: Add required FSP UPD changes for CML
......................................................................

Patch Set 18: Code-Review+1

(2 comments)

https://review.coreboot.org/#/c/31284/18/src/soc/intel/cannonlake/chip.h 
File src/soc/intel/cannonlake/chip.h:

https://review.coreboot.org/#/c/31284/18/src/soc/intel/cannonlake/chip.h@109 
PS18, Line 109: 	enum {
It would be good to mention somewhere what PchSerialIoNotInitialized is and what that option does.

https://review.coreboot.org/#/c/31284/18/src/soc/intel/cannonlake/fsp_params... 
File src/soc/intel/cannonlake/fsp_params.c:

https://review.coreboot.org/#/c/31284/18/src/soc/intel/cannonlake/fsp_params... 
PS18, Line 58: (
Not required.