8 comments:
please use braces around macro parameters: `(x)`
Done
no space on unary operators
Done
Patch Set #3, Line 84: {0xea000051, "SATA_IOBP_SP1G3IR"},
missing per-port registers: (address is for port 0, calculate the other addresses accordingly) […]
Done
Patch Set #3, Line 85: {0xea002550, "SATA_IOBP_SP0DTLE_DATA"},
This is SECRR50, and there's up to six of them (one per SATA port): […]
Done
Patch Set #3, Line 86: {0xea002554, "SATA_IOBP_SP0DTLE_EDGE"},
This is SECRR54 and is the same story as SECRR50
Done
Patch Set #3, Line 88: {0xea002754, "SATA_IOBP_SP1DTLE_EDGE"},
Missing global registers: […]
Done
Patch Set #3, Line 90: USBP01
Yes, it's the same as here: https://miro.medium.com/max/670/1*2iJaywnJdqjNeCJQSm-8kw. […]
Done
#define IOBPIRI 0x2330
#define IOBPD 0x2334
#define IOBPS 0x2338
#define IOBPS_READY 0x0001
#define IOBPS_TX_MASK 0x0006
#define IOBPS_MASK 0xff00
#define IOBPS_READ 0x0600
#define IOBPS_WRITE 0x0700
#define IOBPU 0x233a
#define IOBPU_MAGIC 0xf000
Oh, I need to align the values instead of macros.
To view, visit change 41473. To unsubscribe, or for help writing mail filters, visit settings.