Werner Zeh has uploaded this change for review.
fsp_broadwell_de: Provide valid ACPI path names for domain and LPC
Provide ACPI path names for PCI domain and LPC device so that generated
ACPI tables have valid device paths.
Change-Id: I5a97e45ef50ec5ee9d64c5d2834968a02455cf72
Signed-off-by: Werner Zeh <werner.zeh@siemens.com>
---
M src/soc/intel/fsp_broadwell_de/chip.c
M src/soc/intel/fsp_broadwell_de/southcluster.c
2 files changed, 25 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/25534/1
diff --git a/src/soc/intel/fsp_broadwell_de/chip.c b/src/soc/intel/fsp_broadwell_de/chip.c
index b8db395..118fb99 100644
--- a/src/soc/intel/fsp_broadwell_de/chip.c
+++ b/src/soc/intel/fsp_broadwell_de/chip.c
@@ -30,6 +30,15 @@
assign_resources(dev->link_list);
}
+#if IS_ENABLED(CONFIG_HAVE_ACPI_TABLES)
+static const char *domain_acpi_name(const struct device *dev)
+{
+ if (dev->path.type == DEVICE_PATH_DOMAIN)
+ return "PCI0";
+ return NULL;
+}
+#endif
+
static struct device_operations pci_domain_ops = {
.read_resources = pci_domain_read_resources,
.set_resources = pci_domain_set_resources,
@@ -37,6 +46,9 @@
.init = NULL,
.scan_bus = pci_domain_scan_bus,
.ops_pci_bus = pci_bus_default_ops,
+#if IS_ENABLED(CONFIG_HAVE_ACPI_TABLES)
+ .acpi_name = domain_acpi_name
+#endif
};
static struct device_operations cpu_bus_ops = {
diff --git a/src/soc/intel/fsp_broadwell_de/southcluster.c b/src/soc/intel/fsp_broadwell_de/southcluster.c
index 3bf5429..8ad27af 100644
--- a/src/soc/intel/fsp_broadwell_de/southcluster.c
+++ b/src/soc/intel/fsp_broadwell_de/southcluster.c
@@ -263,6 +263,16 @@
}
}
+#if IS_ENABLED(CONFIG_HAVE_ACPI_TABLES)
+static const char *lpc_acpi_name(const struct device *dev)
+{
+ if (dev->path.pci.devfn == LPC_DEV_FUNC)
+ return "LPC0";
+ else
+ return NULL;
+}
+#endif
+
static struct device_operations device_ops = {
.read_resources = sc_read_resources,
.set_resources = pci_dev_set_resources,
@@ -271,6 +281,9 @@
.enable = southcluster_enable_dev,
.scan_bus = scan_lpc_bus,
.ops_pci = &soc_pci_ops,
+#if IS_ENABLED(CONFIG_HAVE_ACPI_TABLES)
+ .acpi_name = lpc_acpi_name,
+#endif
};
static const struct pci_driver southcluster __pci_driver = {
To view, visit change 25534. To unsubscribe, or for help writing mail filters, visit settings.